-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: Split RingTheory.FractionalIdeal.Basic
#9854
Conversation
Should we wait a couple of hours and merge the other PR before splitting? |
Let's merge this one first and then I'll fix the other one and merge it. |
Can you describe the splitting in the PR description? |
bors d+ |
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
The file `RingTheory.FractionalIdeal.Basic` is more than 1600 lines long. This PR splits it into two files: `Basic` and `Operations` following the model of `RingTheory.Ideal.Basic` and `RingTheory.Ideal.Operations`
Build failed: |
Damn, it's the
|
As this PR is labelled bors merge |
The file `RingTheory.FractionalIdeal.Basic` is more than 1600 lines long. This PR splits it into two files: `Basic` and `Operations` following the model of `RingTheory.Ideal.Basic` and `RingTheory.Ideal.Operations` Co-authored-by: Mario Carneiro <mcarneir@andrew.cmu.edu> Co-authored-by: Jz Pan <acme_pjz@hotmail.com>
Pull request successfully merged into master. Build succeeded: |
RingTheory.FractionalIdeal.Basic
RingTheory.FractionalIdeal.Basic
The file
RingTheory.FractionalIdeal.Basic
is more than 1600 lines long. This PR splits it into two files:Basic
andOperations
following the model ofRingTheory.Ideal.Basic
andRingTheory.Ideal.Operations